Skip to content

fix active total stake #4833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix active total stake #4833

wants to merge 6 commits into from

Conversation

@tzemanovic
Copy link
Collaborator

@tzemanovic tzemanovic commented Sep 23, 2025

Describe your changes

fixes #4823

To apply this fix on chain it is required to:

  • update of txs wasms
    • tx_deactivate_validator
    • tx_reactivate_validator
    • tx_unjail_validator
  • coordinated update at specific height with NAMADA_MIGRATION_HEIGHT set - this will trigger the migration included in namadan

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@tzemanovic tzemanovic added PoS governance requires-migration Requires DB migration to update some state labels Sep 23, 2025
@github-actions github-actions bot added the breaking:api public API breaking change label Sep 23, 2025
@tzemanovic tzemanovic force-pushed the fix-active-total-stake branch from 92646c7 to 5166d82 Compare September 24, 2025 10:11
tzemanovic added a commit that referenced this pull request Sep 24, 2025
@tzemanovic
changelog: add #4833
d7cb251
@github-actions github-actions bot added the backport-libs-0.251 Backport libraries to 0.251 maintenance branch label Sep 24, 2025
tzemanovic added a commit that referenced this pull request Sep 24, 2025
@tzemanovic
changelog: add #4833
2950b37
@tzemanovic tzemanovic force-pushed the fix-active-total-stake branch from d7cb251 to 2950b37 Compare September 24, 2025 10:42
@mergify
Copy link
Contributor

mergify bot commented Sep 24, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 8612ac3.

🟢 All jobs passed!

But CI Insights is watching 👀

@tzemanovic tzemanovic force-pushed the fix-active-total-stake branch from 2950b37 to 8612ac3 Compare September 24, 2025 12:31
@tzemanovic tzemanovic added breaking:consensus Consensus breaking change that requires a hard-fork and removed backport-libs-0.251 Backport libraries to 0.251 maintenance branch breaking:api public API breaking change labels Sep 24, 2025
@github-actions github-actions bot added the backport-libs-0.251 Backport libraries to 0.251 maintenance branch label Sep 24, 2025
@brentstone brentstone added this to the Next Release milestone Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brentstone brentstone Awaiting requested review from brentstone

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

backport-libs-0.251 Backport libraries to 0.251 maintenance branch breaking:consensus Consensus breaking change that requires a hard-fork governance PoS requires-migration Requires DB migration to update some state

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

Total active stake iconsistent with total bonded in gov proposal result query

3 participants

@tzemanovic @brentstone